fanziqi
|
ad60a53262
|
review: add code audit annotations and REVIEW.md for v5.1
P0 issues annotated (critical, must fix before live trading):
- signal_engine.py: cooldown blocks reverse-signal position close
- paper_monitor.py + signal_engine.py: pnl_r 2x inflated for TP scenarios
- signal_engine.py: entry price uses 30min VWAP instead of real-time price
- paper_monitor.py + signal_engine.py: concurrent write race on paper_trades
P1 issues annotated (long-term stability):
- db.py: ensure_partitions uses timedelta(30d) causing missed monthly partitions
- signal_engine.py: float precision drift in buy_vol/sell_vol accumulation
- market_data_collector.py: single bare connection with no reconnect logic
- db.py: get_sync_pool initialization not thread-safe
- signal_engine.py: recent_large_trades deque has no maxlen
P2/P3 issues annotated across backend and frontend:
- coinbase_premium KeyError for XRP/SOL symbols
- liquidation_collector: redundant elif condition in aggregation logic
- auth.py: JWT secret hardcoded default, login rate-limit absent
- Frontend: concurrent refresh token race, AuthContext not synced on failure
- Frontend: universal catch{} swallows all API errors silently
- Frontend: serial API requests in LatestSignals, market-indicators over-polling
docs/REVIEW.md: comprehensive audit report with all 34 issues (P0×4, P1×5,
P2×6, P3×4 backend + FE-P1×4, FE-P2×8, FE-P3×3 frontend), fix suggestions
and prioritized remediation roadmap.
|
2026-03-01 17:14:52 +08:00 |
|
root
|
155dc87df3
|
feat: V4 trades page - live trades + delta analysis + sidebar entry, remove from dashboard
|
2026-02-27 11:47:32 +00:00 |
|
root
|
bb187167bb
|
feat: add LiveTradesCard - real-time agg trades display + /api/trades/latest endpoint
|
2026-02-27 11:35:55 +00:00 |
|
root
|
1ab228286c
|
feat: V2.0 auth system - JWT access/refresh, invite codes, route protection, admin CLI, auth gate blur overlay
|
2026-02-27 11:08:57 +00:00 |
|
root
|
11667d4faa
|
feat: add YTD annualized rate to RateCard
|
2026-02-27 10:08:22 +00:00 |
|
root
|
24d9044d9d
|
feat: sidebar layout + unified dashboard with kline, history, signals
|
2026-02-27 09:44:49 +00:00 |
|
root
|
ae1d1f18b3
|
fix: remove duplicate FundingChart from dashboard
|
2026-02-27 08:32:46 +00:00 |
|
root
|
1a7a77e183
|
feat: merge history into dashboard, remove history nav entry
|
2026-02-27 08:25:11 +00:00 |
|
root
|
93043009ac
|
feat: full light theme - white bg, blue accent, responsive navbar
|
2026-02-27 02:26:15 +00:00 |
|
root
|
03218dce04
|
fix: split rate/stats refresh intervals, rates 2s stats 2min
|
2026-02-26 13:57:39 +00:00 |
|
root
|
96468d0d59
|
feat: refresh interval 2s
|
2026-02-26 13:03:24 +00:00 |
|
root
|
44e07eabb2
|
feat: arbitrage engine Phase 0 scaffold - FastAPI + Next.js
|
2026-02-26 12:06:10 +00:00 |
|