fanziqi
|
ad60a53262
|
review: add code audit annotations and REVIEW.md for v5.1
P0 issues annotated (critical, must fix before live trading):
- signal_engine.py: cooldown blocks reverse-signal position close
- paper_monitor.py + signal_engine.py: pnl_r 2x inflated for TP scenarios
- signal_engine.py: entry price uses 30min VWAP instead of real-time price
- paper_monitor.py + signal_engine.py: concurrent write race on paper_trades
P1 issues annotated (long-term stability):
- db.py: ensure_partitions uses timedelta(30d) causing missed monthly partitions
- signal_engine.py: float precision drift in buy_vol/sell_vol accumulation
- market_data_collector.py: single bare connection with no reconnect logic
- db.py: get_sync_pool initialization not thread-safe
- signal_engine.py: recent_large_trades deque has no maxlen
P2/P3 issues annotated across backend and frontend:
- coinbase_premium KeyError for XRP/SOL symbols
- liquidation_collector: redundant elif condition in aggregation logic
- auth.py: JWT secret hardcoded default, login rate-limit absent
- Frontend: concurrent refresh token race, AuthContext not synced on failure
- Frontend: universal catch{} swallows all API errors silently
- Frontend: serial API requests in LatestSignals, market-indicators over-polling
docs/REVIEW.md: comprehensive audit report with all 34 issues (P0×4, P1×5,
P2×6, P3×4 backend + FE-P1×4, FE-P2×8, FE-P3×3 frontend), fix suggestions
and prioritized remediation roadmap.
|
2026-03-01 17:14:52 +08:00 |
|
root
|
83dc456119
|
feat: signal page add detailed 5-layer explanation section
|
2026-02-28 14:33:33 +00:00 |
|
root
|
9382d35496
|
ui: compact signal engine layout - smaller panels, tighter spacing, V5.1 title
|
2026-02-28 10:42:51 +00:00 |
|
root
|
0ac2225979
|
feat: add XRP and SOL symbols (4 coins total)
|
2026-02-28 10:11:05 +00:00 |
|
root
|
ec6a8fc64d
|
fix: rename signal-history API to avoid route conflict + restart backfill
|
2026-02-28 06:22:32 +00:00 |
|
root
|
424cb993f8
|
feat: signal history list + always compute scoring even without signal
|
2026-02-28 06:09:32 +00:00 |
|
root
|
2e969f68b4
|
fix: parse JSONB string from asyncpg + frontend parseVal fallback
|
2026-02-28 05:49:42 +00:00 |
|
root
|
9525b06710
|
fix: market indicators JSONB parsing + fallback layer scores
|
2026-02-28 05:42:42 +00:00 |
|
root
|
340d8eb3a1
|
feat: V5.1 frontend - 5-layer scoring display + market indicators panel
|
2026-02-28 05:33:40 +00:00 |
|
root
|
35fcb7cef0
|
feat: V5 signals page - CVD三轨+ATR+VWAP+大单阈值实时展示+信号状态
|
2026-02-27 15:34:11 +00:00 |
|
root
|
93043009ac
|
feat: full light theme - white bg, blue accent, responsive navbar
|
2026-02-27 02:26:15 +00:00 |
|